Remove the need for _gtk_tree_view_column_get_focus_area
authorKristian Rietveld <kris@gtk.org>
Sun, 5 Dec 2010 16:10:21 +0000 (17:10 +0100)
committerKristian Rietveld <kris@gtk.org>
Sun, 5 Dec 2010 16:10:21 +0000 (17:10 +0100)
gtk/gtktreeprivate.h
gtk/gtktreeview.c
gtk/gtktreeviewcolumn.c

index 837801efac7f3339468be26a0c75981f8b89fb7c..6cb1ffcae1007570ae567b838c97bae0b4769dfd 100644 (file)
@@ -134,10 +134,6 @@ void                 _gtk_tree_view_column_cell_render      (GtkTreeViewColumn  *tree_column,
                                                          const GdkRectangle *cell_area,
                                                          guint               flags,
                                                           gboolean            draw_focus);
-void             _gtk_tree_view_column_get_focus_area   (GtkTreeViewColumn  *tree_column,
-                                                         const GdkRectangle *background_area,
-                                                         const GdkRectangle *cell_area,
-                                                         GdkRectangle       *focus_area);
 void             _gtk_tree_view_column_cell_set_dirty   (GtkTreeViewColumn  *tree_column,
                                                          gboolean            install_handler);
 gboolean          _gtk_tree_view_column_cell_get_dirty   (GtkTreeViewColumn  *tree_column);
index c63ec24ccc37801126e454628044121a7ae8101e..2d16f468b7aa1f04f9d20b714bd76c2ab9823939 100644 (file)
@@ -9367,42 +9367,31 @@ gtk_tree_view_clamp_column_visible (GtkTreeView       *tree_view,
        * focus cell is bigger than the page size, we make sure the
        * left-hand side of the cell is visible).
        *
-       * If the column does not have those so-called special cells, we
+       * If the column does not have an activatable cell, we
        * make sure the left-hand side of the column is visible.
        */
 
       if (focus_to_cell && gtk_tree_view_has_can_focus_cell (tree_view))
         {
-         GtkTreePath *cursor_path;
-         GdkRectangle background_area, cell_area, focus_area;
+          GtkCellArea *cell_area;
+          GtkCellRenderer *focus_cell;
 
-         cursor_path = gtk_tree_row_reference_get_path (tree_view->priv->cursor);
+          cell_area = gtk_cell_layout_get_area (GTK_CELL_LAYOUT (column));
+          focus_cell = gtk_cell_area_get_focus_cell (cell_area);
 
-         gtk_tree_view_get_cell_area (tree_view,
-                                      cursor_path, column, &cell_area);
-         gtk_tree_view_get_background_area (tree_view,
-                                            cursor_path, column,
-                                            &background_area);
-
-         gtk_tree_path_free (cursor_path);
-
-         _gtk_tree_view_column_get_focus_area (column,
-                                               &background_area,
-                                               &cell_area,
-                                               &focus_area);
-
-         x = focus_area.x;
-         width = focus_area.width;
-
-         if (width < tree_view->priv->hadjustment->page_size)
-           {
-             if ((tree_view->priv->hadjustment->value + tree_view->priv->hadjustment->page_size) < (x + width))
-               gtk_adjustment_set_value (tree_view->priv->hadjustment,
-                                         x + width - tree_view->priv->hadjustment->page_size);
-             else if (tree_view->priv->hadjustment->value > x)
-               gtk_adjustment_set_value (tree_view->priv->hadjustment, x);
-           }
-       }
+          if (gtk_tree_view_column_cell_get_position (column, focus_cell,
+                                                      &x, &width))
+            {
+              if (width < tree_view->priv->hadjustment->page_size)
+                {
+                  if (tree_view->priv->hadjustment->value + tree_view->priv->hadjustment->page_size < x + width)
+                    gtk_adjustment_set_value (tree_view->priv->hadjustment,
+                                              x + width - tree_view->priv->hadjustment->page_size);
+                  else if (tree_view->priv->hadjustment->value > x)
+                    gtk_adjustment_set_value (tree_view->priv->hadjustment, x);
+                }
+            }
+        }
 
       gtk_adjustment_set_value (tree_view->priv->hadjustment, x);
     }
index 6b86fd32e511497d28b54c8d3fcbc623a3af7575..1fa4cf0bb69d2549674bb5c4752e30864396792f 100644 (file)
@@ -2811,26 +2811,6 @@ _gtk_tree_view_column_cell_event (GtkTreeViewColumn  *tree_column,
                               flags);
 }
 
-void
-_gtk_tree_view_column_get_focus_area (GtkTreeViewColumn  *tree_column,
-                                     const GdkRectangle *background_area,
-                                     const GdkRectangle *cell_area,
-                                     GdkRectangle       *focus_area)
-{
-  /* FIXME */
-#if 0
-  gtk_tree_view_column_cell_process_action (tree_column,
-                                           NULL,
-                                           background_area,
-                                           cell_area,
-                                           0,
-                                           CELL_ACTION_FOCUS,
-                                           focus_area,
-                                           NULL, NULL, NULL);
-#endif
-}
-
-
 /**
  * gtk_tree_view_column_cell_is_visible:
  * @tree_column: A #GtkTreeViewColumn